fix(hotkeys): make copy line up/down hotkeys editable by Abdulrehman-PIAIC80387 · Pull Request #10241 · marimo-team/marimo

Abdulrehman-PIAIC80387 · 2026-07-20T10:05:36Z

This pull request was authored by a coding agent.

📝 Summary

Copy line(s) up / Copy line(s) down appear in the Keyboard Shortcuts panel but are marked editable: false, so the panel advertises two rows it silently refuses to customize.

That flag was a deliberate stopgap in #6843, which said as much:

since right now we don't override it in the codemirror settings, this needs to be set to not editable

The commands are served by CodeMirror's built-in defaultKeymap, which hardcodes Shift-Alt-Arrow, so marimo's hotkey config never reached them. @mscolnick invited a follow-up FR for this in #6338 ("we can look into making it editable. mind filing a FR?"), which became #7056.

🔍 Description of Changes

Uses the override mechanism already established in keymaps.ts for toggleComment / toggleBlockComment — no new machinery:

frontend/src/core/codemirror/keymaps/keymaps.ts — add copyLineUp/copyLineDown to OVERRIDDEN_COMMANDS (filters the hardcoded bindings out of the default keymap), then re-bind them in overrideKeymap() via keymap.getHotkey(...) so they follow user config.
frontend/src/core/hotkeys/hotkeys.ts — remove editable: false from both entries.

Default keybindings are unchanged — only the ability to reconfigure them is added. Applies to both the default and vim presets, since keymapBundle installs overrideKeymap for each.

Both directions are included because the issue asks for both and they share one mechanism.

🎥 Demo

Recorded against a local dev build on this branch.

The clip shows, in order:

"Copy line(s) down" now has an edit affordance in the Keyboard Shortcuts panel (on main it is greyed out / non-editable).
Rebinding it to a new key.
Pressing that new key in a cell duplicates the line — i.e. the rebind actually drives CodeMirror, not just the UI label.

marimo-shortcut-demo.mp4

🧪 Testing

make fe-check — clean
pnpm vitest run src/core/codemirror src/core/hotkeys — 660 passed, 1 skipped (47 files)
The keymap collision snapshot in setup.test.ts is unchanged at 18 duplicates — no new conflicts.

The pre-existing generic assertions in keymaps.test.ts (overrideKeymap().length === OVERRIDDEN_COMMANDS.size, and no overridden command surviving in the filtered keymap) picked up the two new commands automatically.

Added a test asserting an override to Ctrl-D actually reaches the keymap — the exact rebinding @mullimanko asked for. It guards the user-facing behavior rather than the plumbing: reverting the overrideKeymap half while leaving editable on would still pass the generic tests, but fails this one.

📋 Pre-Review Checklist

For large changes, or changes that affect the public API: this change was discussed or approved through an issue — see document shortcut to "copy line down" in the shortcuts page in the marimo editor #6338 where a maintainer invited this FR; awaiting explicit go-ahead here.
Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

I have read the contributor guidelines.
Documentation has been updated where applicable — no public API or docs change; the shortcut is self-documenting in the panel.
Tests have been added for the changes made.

vercel · 2026-07-20T10:05:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
marimo-docs	Ready	Preview, Comment	Jul 20, 2026 10:14am

github-actions · 2026-07-20T10:05:47Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Copy line(s) up/down were listed in the Keyboard Shortcuts panel but marked `editable: false`, because they were served by CodeMirror's built-in `defaultKeymap` and so never consulted marimo's hotkey config. Route both commands through the existing override mechanism already used by `toggleComment`/`toggleBlockComment`: add them to OVERRIDDEN_COMMANDS so the hardcoded bindings are filtered out of the default keymap, then re-bind them in `overrideKeymap` using the configured hotkey. Default keybindings are unchanged. Closes marimo-team#7056

Abdulrehman-PIAIC80387 · 2026-07-20T10:07:57Z

I have read the CLA Document and I hereby sign the CLA

Abdulrehman-PIAIC80387 · 2026-07-20T10:09:21Z

recheck

Copilot

Pull request overview

Enables user customization of the editor hotkeys for CodeMirror’s built-in “copy line up/down” commands by filtering their hardcoded default bindings and re-binding them through marimo’s hotkey provider, and by marking these actions as editable in the shortcuts UI.

Changes:

Remove the editable: false restriction for cell.copyLineUp / cell.copyLineDown so they can be customized in the Keyboard Shortcuts panel.
Override CodeMirror’s defaultKeymap bindings for copyLineUp / copyLineDown and re-bind them using keymap.getHotkey(...) so user overrides take effect.
Add a focused unit test to assert that user overrides (e.g., Ctrl-d) propagate into the resulting CodeMirror keymap bindings.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
frontend/src/core/hotkeys/hotkeys.ts	Makes “Copy line(s) up/down” editable by removing the explicit non-editable flags.
frontend/src/core/codemirror/keymaps/keymaps.ts	Filters out CodeMirror’s hardcoded bindings for copyLineUp/down and re-binds them via marimo’s configured hotkeys.
frontend/src/core/codemirror/keymaps/tests/keymaps.test.ts	Adds a regression test ensuring hotkey overrides actually reach the CodeMirror keymap for copyLineUp/down.

  "cell.copyLineUp": {
    name: "Copy line(s) up",
    group: "Editing",
    key: "Alt-Shift-ArrowUp",
-    editable: false,
  },


kirangadhave · 2026-07-23T16:53:13Z

@Abdulrehman-PIAIC80387 Can you please attach a demo video. I'll be happy to approve after that

Abdulrehman-PIAIC80387 · 2026-07-24T08:02:26Z

Hi @kirangadhave — added a demo video to the PR description showing "Copy line(s) down" being made editable, rebound to a new key, and that key duplicating a line in a cell.

Further comments welcome.

vercel Bot deployed to Preview July 20, 2026 10:06 View deployment

Abdulrehman-PIAIC80387 force-pushed the fix/editable-copy-line-hotkeys-7056 branch from 7c1ea93 to f8e6a53 Compare July 20, 2026 10:07

vercel Bot deployed to Preview July 20, 2026 10:14 View deployment

Abdulrehman-PIAIC80387 marked this pull request as ready for review July 22, 2026 08:13

mscolnick requested a review from kirangadhave July 23, 2026 13:09

kirangadhave requested a review from Copilot July 23, 2026 16:41

Copilot started reviewing on behalf of kirangadhave July 23, 2026 16:41 View session

Copilot AI reviewed Jul 23, 2026

View reviewed changes

Comment thread frontend/src/core/hotkeys/hotkeys.ts

Comment on lines 255 to 259

"cell.copyLineUp": {

name: "Copy line(s) up",

group: "Editing",

key: "Alt-Shift-ArrowUp",

editable: false,

},

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(hotkeys): make copy line up/down hotkeys editable#10241

fix(hotkeys): make copy line up/down hotkeys editable#10241
Abdulrehman-PIAIC80387 wants to merge 1 commit into
marimo-team:mainfrom
Abdulrehman-PIAIC80387:fix/editable-copy-line-hotkeys-7056

Abdulrehman-PIAIC80387 commented Jul 20, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

Abdulrehman-PIAIC80387 commented Jul 20, 2026

Uh oh!

Abdulrehman-PIAIC80387 commented Jul 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

kirangadhave commented Jul 23, 2026

Uh oh!

Abdulrehman-PIAIC80387 commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Abdulrehman-PIAIC80387 commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

🔍 Description of Changes

🎥 Demo

🧪 Testing

📋 Pre-Review Checklist

✅ Merge Checklist

Uh oh!

vercel Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abdulrehman-PIAIC80387 commented Jul 20, 2026

Uh oh!

Abdulrehman-PIAIC80387 commented Jul 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

kirangadhave commented Jul 23, 2026

Uh oh!

Abdulrehman-PIAIC80387 commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Abdulrehman-PIAIC80387 commented Jul 20, 2026 •

edited

Loading

vercel Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading